The PR adds a confirm action as <button className="rounded-md bg-blue-600 px-4 py-2 text-white">Confirm</button>. The design system already has <Button variant="primary">. The new control misses the loading spinner, the focus ring, the disabled opacity, and the type default the shared component already handles.
I’ve started treating a raw button with utility classes as a fork, not as a harmless one-off. If the visual is close to an existing variant, use the variant. If it is not, the question is whether you need a new variant — not a third implementation in a leaf file.
Why the raw button shows up
Public React snippets start from <button>. The model can write that without opening components/Button. Variant names are local (primary, danger, ghost, subtle) and easy to skip when the prompt only says “add a confirm button.”
You also lose behavior that is easy to forget in review: aria-busy while a mutation is in flight, preventing double submits, icon spacing, and the small-size styles used in tables and dialogs.
A simple Button policy
- New actions use the existing
Buttoncomponent and a named variant - Do not copy utility classes off a screenshot of the primary button
- A new variant is a design-system change, with a story, not a one-off class string in a feature PR
- Native
<button>is fine inside the design-system file itself, or for a genuine exception documented in the PR
Paste the variant list and one usage example into the prompt. In review, search the diff for raw <button> and for bg-blue- / bg-primary utilities outside the Button source.
What to put in the prompt
Use the existing Button component and its variants (primary, secondary, danger, ghost).
Do not style a raw <button> with utilities.
If none of the variants fit, say so and propose a new variant; do not invent a one-off in this file.
Keep loading and disabled behavior consistent with neighboring actions.
Reject / send back
Reject
- A raw
<button>that visually clones an existing variant - A new
ConfirmButtonwrapper that only hard-codes primary styles - Utility color and padding that drift from the size scale
- A missing loading or disabled state the shared Button already supports
Accept
- An action that uses
<Button variant="…">and the existing size - A design-system PR that adds a named variant with a story
- A documented exception, with a reason, when a native button is required
